You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
1d31a139f5
Our recent work in fieldToAlias worked well when the embedded field declaration (using an alias) was in the same package as the use of that field. We would have the *ast.Ident for the field declaration, so types.Info.Uses would give us the TypeName for the alias. Unfortunately, if the declaration was in a dependency package, we did not have that same *ast.Ident, as we weren't parsing the source code for dependencies for type-checking. This resulted in us incorrectly obfuscating the use of such an embedded field: > garble build [stderr] # test/main JtzmzxWf.go:4: unknown field 'ExternalForeignAlias' in struct literal of type _BdSNiEL.Vcs_smer To fix this, look through the direct imports of the package defining the field to find an alias under the exact same name. Not a foolproof solution, as there's a TODO, but it should work for most cases. Fixes the obfuscation of google.golang.org/grpc/internal/status, too. Updates #349. |
3 years ago | |
|---|---|---|
| .. | ||
| bench-cache | 3 years ago | |
| bench-nocache | 3 years ago | |
| mod | 3 years ago | |
| scripts | 3 years ago | |