You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
af517a20f8
First, make isPrivate panic on malformed import paths, since that should never happen. This catches the errors that some users had run into with packages like gopkg.in/yaml.v2 and github.com/satori/go.uuid: panic: malformed import path "gopkg.in/garbletest%2ev2": invalid char '%' This seems to trigger when a module path contains a dot after the first element, *and* that module is fetched via the proxy. This results in the toolchain URL-encoding the second dot, and garble ends up seeing that encoded path. We reproduce this behavior with a fake gopkg.in module added to the test module proxy. Using yaml.v2 directly would have been easier, but it's pretty large. Note that we tried a replace directive, but that does not trigger the URL-encoding bug. Also note that we do not obfuscate the gopkg.in package; that's fine, as the isPrivate path validity check catches the bug either way. For now, make initImport use url.PathUnescape to work around this issue. The underlying bug is likely in either the goobj2 fork, or in the upstream Go toolchain itself. hashImport also gives a better error if it cannot find a package now, rather than just an "empty seed" panic. Finally, the sanity check in isPrivate unearthed the fact that we do not support garbling test packages at all, since they were invalid paths which never matched GOPRIVATE. Add an explicit check and TODO about that. Fixes #224. Fixes #228. |
4 years ago | |
|---|---|---|
| .. | ||
| golang.org_x_text_v0.0.0-20170915032832-14c0d48ead0c.txt | 5 years ago | |
| gopkg.in_garbletest.v2_v2.999.0.txt | 4 years ago | |
| rsc.io_quote_v1.5.2.txt | 5 years ago | |
| rsc.io_sampler_v1.2.1.txt | 5 years ago | |
| rsc.io_sampler_v1.3.0.txt | 5 years ago | |
| rsc.io_sampler_v1.99.99.txt | 5 years ago | |