You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
9fc19e8bdf
When splitFlagsFromFiles saw "-p foo/bar.go", it thought that was the first Go file, when in fact it's not. We didn't notice because such import paths are pretty rare, but they do exist, like github.com/nats-io/nats.go. Before the fix, the added test case fails as expected: > garble build -tags buildtag [stderr] # test/main/goextension.go open test/main/goextension.go: no such file or directory We could go through the trouble of teaching splitFlagsFromFiles about all of the flags understood by the compiler and linker, but that feels like far more code than the small alternative we went with. And I'm pretty sure the alternative will work pretty reliably for now. Fixes #539. |
3 years ago | |
|---|---|---|
| .. | ||
| asm.txt | 3 years ago | |
| basic.txt | 3 years ago | |
| cgo.txt | 3 years ago | |
| crossbuild.txt | 3 years ago | |
| debugdir.txt | 3 years ago | |
| embed.txt | 3 years ago | |
| gogarble.txt | 3 years ago | |
| goversion.txt | 3 years ago | |
| help.txt | 3 years ago | |
| implement.txt | 3 years ago | |
| imports.txt | 3 years ago | |
| init.txt | 3 years ago | |
| ldflags.txt | 3 years ago | |
| linkname.txt | 3 years ago | |
| literals.txt | 3 years ago | |
| modinfo.txt | 3 years ago | |
| plugin.txt | 3 years ago | |
| position.txt | 3 years ago | |
| reflect.txt | 3 years ago | |
| reverse.txt | 3 years ago | |
| seed-cache.txt | 3 years ago | |
| seed.txt | 3 years ago | |
| syntax.txt | 3 years ago | |
| test.txt | 3 years ago | |
| tiny.txt | 3 years ago | |
| typeparams.txt | 3 years ago | |