You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8edde922ee
Remove some asthelper APIs that haven't been used for some time. They can be recovered from the git history if needed again. One type assertion in the literals package is always true. Embedded field objects are handled near the top of transformGo, so the extra !obj.Embedded() check was always true. Remove it. We always obfuscate standalone funcs now, so the obfuscatedTypesPackage check is no longer necessary. This was necessary when we used to not obfuscate func names when they were used in linkname directives. The workaround for test package imports in obfuscatedTypesPackage I had to add a few commits ago no longer seems to be necessary. This might be thanks to the simplification with functions in the paragraph just above. It's impossible to run garble without -trimpath nowadays, as we error before the build even starts: $ go build -toolexec=garble go tool compile: exit status 1 cannot open shared file, this is most likely due to not running "garble [command]" When run as "garble build", the trimpath flag is always set. So the check in alterTrimpath never triggers anymore, and couldn't be tested. Finally, simplify the handling of comment syntax in printFile, and add a few TODOs for other code paths not covered by our existing tests. Total code coverage is up from 90.3% to 91.0%. |
4 years ago | |
|---|---|---|
| .. | ||
| asthelper | 4 years ago | |
| literals | 4 years ago | |