You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
68f07389b2
obfuscatedTypesPackage is used to figure out if a name in a dependency package was obfuscated or not. For example, if that package used reflection on a named type, it wasn't obfuscated, so we must have the same information to not obfuscate the same name downstream. obfuscatedTypesPackage could return nil if the package was indirectly imported, though. This can happen if a direct import has a function that returns an indirect type, or if a direct import exposes a name that's a type alias to an indirect type. We sort of dealt with this in two pieces of code by checking for obfPkg!=nil, but a third one did not have this check and caused a panic in the added test case: --- FAIL: TestScripts/reflect (0.81s) testscript.go:397: > env GOPRIVATE=test/main > garble build [stderr] # test/main panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x8a5e39] More importantly though, the nil check only avoids panics. It doesn't fix the root cause of the problem: that importcfg does not contain indirectly imported packages. The added test case would still fail, as we would obfuscate a type in the main package, but not in the indirectly imported package where the type is defined. To fix this, resurrect a bit of code from earlier garble versions, which uses "go list -toolexec=garble" to fetch a package's export file. This lets us fill the indirect import gaps in importcfg, working around the problem entirely. This solution is still not particularly great, so we add a TODO about possibly rethinking this in the future. It does add some overhead and complexity, though thankfully indirect imports should be uncommon. This fixes a few panics while building the protobuf module. |
4 years ago | |
|---|---|---|
| .. | ||
| asm.txt | 5 years ago | |
| basic.txt | 5 years ago | |
| cgo.txt | 5 years ago | |
| crossbuild.txt | 5 years ago | |
| debugdir.txt | 5 years ago | |
| embed.txt | 5 years ago | |
| goprivate.txt | 5 years ago | |
| goversion.txt | 5 years ago | |
| help.txt | 5 years ago | |
| implement.txt | 4 years ago | |
| imports.txt | 5 years ago | |
| init.txt | 5 years ago | |
| ldflags.txt | 5 years ago | |
| linkname.txt | 5 years ago | |
| literals.txt | 5 years ago | |
| modinfo.txt | 5 years ago | |
| plugin.txt | 5 years ago | |
| position.txt | 5 years ago | |
| reflect.txt | 4 years ago | |
| reverse.txt | 4 years ago | |
| seed.txt | 5 years ago | |
| syntax.txt | 5 years ago | |
| test.txt | 5 years ago | |
| tiny.txt | 5 years ago | |