You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
60dbece24f
When obfuscating the following piece of code:
func issue_573(s struct{ f int }) {
var _ *int = &s.f
/*x*/
}
the function body would roughly end up printed as:
we would roughly end up with:
var _ *int = &dZ4xYx3N
/*x*/.rbg1IM3V
Note that the /*x*/ comment got moved earlier in the source code.
This happens because the new identifiers are longer, so the printer
thinks that the selector now ends past the comment.
That would be fine - we don't really mind where comments end up,
because these non-directive comments end up being removed anyway.
However, the resulting syntax is wrong, as the period for the selector
must be on the first line rather than the second.
This is a go/printer bug that we should fix upstream,
but until then, we must work around it in Go 1.18.x and 1.19.x.
The fix is somewhat obvious in hindsight. To reduce the chances that
go/printer will trip over comments and produce invalid syntax,
get rid of most comments before we use the printer.
We still keep the removal of comments after printing,
since go/printer consumes some comments in ast.Node Doc fields.
Add the minimized unit test case above, and add the upstream project
that found this bug to check-third-party.
andybalholm/brotli helps cover a compression algorithm and ccgo code
generation from C to Go, and it's also a fairly popular module,
particular with HTTP implementations which want pure-Go brotli.
While here, fix the check-third-party script: it was setting GOFLAGS
a bit too late, so it may run `go get` on the wrong mod file.
Fixes #573.
|
3 years ago | |
|---|---|---|
| .. | ||
| asm.txt | 3 years ago | |
| basic.txt | 3 years ago | |
| cgo.txt | 3 years ago | |
| crossbuild.txt | 3 years ago | |
| debugdir.txt | 3 years ago | |
| embed.txt | 3 years ago | |
| goenv.txt | 3 years ago | |
| gogarble.txt | 3 years ago | |
| goversion.txt | 3 years ago | |
| help.txt | 3 years ago | |
| implement.txt | 3 years ago | |
| imports.txt | 3 years ago | |
| init.txt | 3 years ago | |
| ldflags.txt | 3 years ago | |
| linkname.txt | 3 years ago | |
| literals.txt | 3 years ago | |
| modinfo.txt | 3 years ago | |
| plugin.txt | 3 years ago | |
| position.txt | 3 years ago | |
| reflect.txt | 3 years ago | |
| reverse.txt | 3 years ago | |
| seed-cache.txt | 3 years ago | |
| seed.txt | 3 years ago | |
| syntax.txt | 3 years ago | |
| test.txt | 3 years ago | |
| tiny.txt | 3 years ago | |
| typeparams.txt | 3 years ago | |