You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
5fa4acf580
Every now and then, a CI run would fail: FAIL: testdata/scripts/reflect.txt:7: unexpected match for ["main.go"] in main These were rare, and very hard to reproduce or debug. My best guess is that, since "main.go" is a short string and we use random eight-character obfuscated filenames ending with ".go", it was possible that the random filename happened to end in "main" in some cases. Given the base64 encoding, the chances of a single suffix collision are about 0.000006%. Note, however, that a single obfuscated build will most likely obfuscate many filenames, especially for the tests obfuscating multiple packages. For a single CI run with many tests across three OSs, the chances of any collision are likely very low, but realistic. All this has a simple fix: use longer filenames to match with. We choose "garble_main.go" since it's long enough, but also because it's still clear it's a "main" Go file, and it's very unlikely to cause conflicts with filenames in upstream Go given the "garble_" prefix. |
4 years ago | |
|---|---|---|
| .. | ||
| bench-cache | 5 years ago | |
| bench-nocache | 5 years ago | |
| mod | 5 years ago | |
| scripts | 4 years ago | |