You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
4e9ee17ec8
Now that we've dropped support for Go 1.15.x, we can finally rely on this environment variable for toolexec calls, present in Go 1.16. Before, we had hacky ways of trying to figure out the current package's import path, mostly from the -p flag. The biggest rough edge there was that, for main packages, that was simply the package name, and not its full import path. To work around that, we had a restriction on a single main package, so we could work around that issue. That restriction is now gone. The new code is simpler, especially because we can set curPkg in a single place for all toolexec transform funcs. Since we can always rely on curPkg not being nil now, we can also start reusing listedPackage.Private and avoid the majority of repeated calls to isPrivate. The function is cheap, but still not free. isPrivate itself can also get simpler. We no longer have to worry about the "main" edge case. Plus, the sanity check for invalid package paths is now unnecessary; we only got malformed paths from goobj2, and we now require exact matches with the ImportPath field from "go list -json". Another effect of clearing up the "main" edge case is that -debugdir now uses the right directory for main packages. We also start using consistent debugdir paths in the tests, for the sake of being easier to read and maintain. Finally, note that commandReverse did not need the extra call to "go list -toolexec", as the "shared" call stored in the cache is enough. We still call toolexecCmd to get said cache, which should probably be simplified in a future PR. While at it, replace the use of the "-std" compiler flag with the Standard field from "go list -json". |
4 years ago | |
|---|---|---|
| .. | ||
| asm.txt | 4 years ago | |
| basic.txt | 4 years ago | |
| cgo.txt | 4 years ago | |
| debugdir.txt | 4 years ago | |
| goprivate.txt | 4 years ago | |
| goversion.txt | 4 years ago | |
| help.txt | 4 years ago | |
| implement.txt | 4 years ago | |
| imports.txt | 4 years ago | |
| init.txt | 4 years ago | |
| ldflags.txt | 4 years ago | |
| linkname.txt | 4 years ago | |
| literals.txt | 4 years ago | |
| modinfo.txt | 4 years ago | |
| plugin.txt | 4 years ago | |
| position.txt | 4 years ago | |
| reverse.txt | 4 years ago | |
| seed.txt | 4 years ago | |
| syntax.txt | 4 years ago | |
| test.txt | 4 years ago | |
| tiny.txt | 4 years ago | |