You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
3fbefbbacf
The _gomod_.go file inserted by the Go toolchain no longer shows up; it's likely that either the -trimpath or -buildvcs=false flags are preventing that extra bit of work from happening entirely. The modinfo.txt test ensures that we're not breaking, and the inner lines of code weren't hit as part of `go test`. It also appears that we don't need to avoid obfuscating functions defined with an `//export` directive. This is likely because cgo runs as a pre-process step compared to the compiler, so us removing the directive later does not make a difference. We might need to revisit this in the future if we implement obfuscating Go code instead of builds, e.g. `garble export`. Just in case, I've expanded the cgo.txt test to also include one more kind of cgo integration: an "import C" block including a C header file. Either of these changes are slightly risky, as our tests don't cover all edge cases. We've just done a release, so now is the time to try them. |
3 years ago | |
|---|---|---|
| .. | ||
| bench | 3 years ago | |
| mod | 3 years ago | |
| scripts | 3 years ago | |