You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
2fad0e1583
The docs for go/importer.ForCompiler say: The lookup function is called each time the resulting importer needs to resolve an import path. In this mode the importer can only be invoked with canonical import paths (not relative or absolute ones); it is assumed that the translation to canonical import paths is being done by the client of the importer. We use a lookup func for two reasons: first, to support modules, and second, to be able to use our information from "go list -json -export". However, go/types does not canonicalize import paths before calling ImportFrom. This is somewhat understandable; it doesn't know whether an importer was created with a lookup func, and ImportFrom only requires the input path to be canonicalized in that scenario. When the lookup func is nil, the importer canonicalizes by itself via go/build.Import. Before this change, the added crossbuild test would fail: > garble build net/http [stderr] # vendor/golang.org/x/crypto/chacha20 typecheck error: /usr/lib/go/src/vendor/golang.org/x/crypto/chacha20/chacha_generic.go:10:2: could not import crypto/cipher (can't find import: "crypto/cipher") # vendor/golang.org/x/text/secure/bidirule typecheck error: /usr/lib/go/src/vendor/golang.org/x/text/secure/bidirule/bidirule.go:12:2: could not import errors (can't find import: "errors") # vendor/golang.org/x/crypto/cryptobyte typecheck error: /usr/lib/go/src/vendor/golang.org/x/crypto/cryptobyte/asn1.go:8:16: could not import encoding/asn1 (can't find import: "encoding/asn1") # vendor/golang.org/x/text/unicode/norm typecheck error: /usr/lib/go/src/vendor/golang.org/x/text/unicode/norm/composition.go:7:8: could not import unicode/utf8 (can't find import: "unicode/utf8") This is because we'd fall back to importer.Default, which only knows how to find packages in $GOROOT/pkg. Those are missing for cross-builds, unsurprisingly, as those built archives end up in the build cache. After this change, we properly support importing std-vendored packages, so we can get rid of the importer.Default workaround. And, by extension, cross-builds now work as well. Note that, in the added test script, the full build of the binary fails, as there seems to be some sort of linker problem: > garble build [stderr] # test/main d9rqJyxo.uoqIiDs5: relocation target runtime.os9A16A3 not defined We leave that as a TODO for now, as this change is subtle enough as it is. |
5 years ago | |
|---|---|---|
| .. | ||
| asm.txt | 5 years ago | |
| basic.txt | 5 years ago | |
| cgo.txt | 5 years ago | |
| crossbuild.txt | 5 years ago | |
| debugdir.txt | 5 years ago | |
| embed.txt | 5 years ago | |
| goprivate.txt | 5 years ago | |
| goversion.txt | 5 years ago | |
| help.txt | 5 years ago | |
| implement.txt | 5 years ago | |
| imports.txt | 5 years ago | |
| init.txt | 5 years ago | |
| ldflags.txt | 5 years ago | |
| linkname.txt | 5 years ago | |
| literals.txt | 5 years ago | |
| modinfo.txt | 5 years ago | |
| plugin.txt | 5 years ago | |
| position.txt | 5 years ago | |
| reverse.txt | 5 years ago | |
| seed.txt | 5 years ago | |
| syntax.txt | 5 years ago | |
| test.txt | 5 years ago | |
| tiny.txt | 5 years ago | |