You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
2fa5697189
The added test case used to crash garble: panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x8fe71b] goroutine 1 [running]: golang.org/x/tools/go/ast/astutil.Apply.func1(0xc0001e8880, 0xc000221570) /go/pkg/mod/golang.org/x/tools@v0.0.0-20210115202250-e0d201561e39/go/ast/astutil/rewrite.go:47 +0x97 panic(0x975bc0, 0xd6c610) /sdk/go1.15.8/src/runtime/panic.go:969 +0x1b9 go/types.(*Named).Obj(...) /sdk/go1.15.8/src/go/types/type.go:473 mvdan.cc/garble.isTestSignature(0xc0001e7080, 0xa02e84) /src/garble/main.go:1170 +0x7b mvdan.cc/garble.(*transformer).transformGo.func2(0xc000122df0, 0xaac301) /src/garble/main.go:1028 +0xff1 We were assuming that the first parameter was a named type, but that might not be the case. This crash was found out in the wild, from which a minimal repro was written. We add two variants of it to the test data, just in case. |
5 years ago | |
|---|---|---|
| .. | ||
| bench | 5 years ago | |
| mod | 5 years ago | |
| scripts | 5 years ago | |