You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
c26734c668
First, teach scripts/gen-go-std-tables.sh to omit test packages, since runtime/metrics_test would always result in an error. Instead, make transformLinkname explicitly skip that package, leaving a comment about a potential improvement if needed. Second, the only remaining "not found" error we had was "maps" on 1.20, so rewrite that check based on ImportPath and GoVersionSemver. Third, detect packages with the "exclude all Go files" error by looking at CompiledGoFiles and IgnoredGoFiles, which is less brittle. This means that we are no longer doing any filtering on pkg.Error.Err, which means we are less likely to break with Go error message changes. Fourth, the check on pkg.Incomplete is now obsolete given the above, meaning that the CompiledGoFiles length check is plenty. Finally, stop trying to be clever about how we print errors. Now that we're no longer skipping packages based on pkg.Error values, printing pkg.DepsErrors was causing duplicate messages in the output. Simply print pkg.Error values with only minimal tweaks: including the position if there is any, and avoiding double newlines. Overall, this makes our logic a lot less complicated, and garble still works the way we want it to. |
1 year ago | |
|---|---|---|
| .. | ||
| bench | 3 years ago | |
| mod | 2 years ago | |
| script | 1 year ago | |