garble

Commit Graph

Author	SHA1	Message	Date
Daniel Martí	14d3803a7b	fix hashing of generic field names Trying to make Go master work, I noticed that crypto/tls still failed to build. The reason was generic structs; we would badly obfuscate their field names when the types are instantiated: > garble build [stderr] # test/main Z4ZpcbMj.go:4: unknown field 'FOpszkrN' in struct literal of type SYdpWfK5[string] Z4ZpcbMj.go:5: m8hLTotb.FypXrbTd undefined (type SYdpWfK5[string] has no field or method FypXrbTd) exit status 2 See the added comment for what happened and how we fixed it. And add tests.	3 years ago
Daniel Martí	61bd95bb89	add a test with generic code This ensures that we support obfuscating builds containing the use of type parameters, the new feature in Go 1.18. The test is small for now, but we can extend it over time. There was just one bug that kept the code from obfuscating properly; that has been fixed in https://go.dev/cl/405194, and we update x/tools to the latest master version to include it. Fixes #414.	3 years ago

Author

SHA1

Message

Date

Daniel Martí

14d3803a7b

fix hashing of generic field names

Trying to make Go master work, I noticed that crypto/tls still failed to
build. The reason was generic structs; we would badly obfuscate their
field names when the types are instantiated:

	> garble build
	[stderr]
	# test/main
	Z4ZpcbMj.go:4: unknown field 'FOpszkrN' in struct literal of type SYdpWfK5[string]
	Z4ZpcbMj.go:5: m8hLTotb.FypXrbTd undefined (type SYdpWfK5[string] has no field or method FypXrbTd)
	exit status 2

See the added comment for what happened and how we fixed it. And add tests.

Daniel Martí

61bd95bb89

add a test with generic code

This ensures that we support obfuscating builds containing the use of
type parameters, the new feature in Go 1.18.
The test is small for now, but we can extend it over time.

There was just one bug that kept the code from obfuscating properly;
that has been fixed in https://go.dev/cl/405194,
and we update x/tools to the latest master version to include it.

Fixes #414.

2 Commits (fa35e6d81ca409aa1dab1a49c5af97d44bb7c9bf)