garble

Commit Graph

Author	SHA1	Message	Date
Daniel Martí	e6fc593f68	set testscript's RequireExplicitExec and RequireUniqueNames The first makes our test scripts more consistent, as all external program executions happen via "exec" and are not as easily confused with custom builtin commands like our "generate-literals". The second catches mistakes if any of our txtar files have duplicate files, where all but one of the contents would be ignored before.	3 years ago
Daniel Martí	30927da637	avoid panic when a package's imports cannot be loaded I mistakenly understood that, when the DepsErrors field has errors, the Error field would contain an error as well. That is not always the case; for example, the imports_missing package in the added test script had DepsErrors set but Error empty, causing a nil dereference panic. Make the code more robust, and report both kinds of load errors. Fixes #694.	3 years ago

Author

SHA1

Message

Date

Daniel Martí

e6fc593f68

set testscript's RequireExplicitExec and RequireUniqueNames

The first makes our test scripts more consistent, as all external
program executions happen via "exec" and are not as easily confused
with custom builtin commands like our "generate-literals".

The second catches mistakes if any of our txtar files have duplicate
files, where all but one of the contents would be ignored before.

Daniel Martí

30927da637

avoid panic when a package's imports cannot be loaded

I mistakenly understood that, when the DepsErrors field has errors,
the Error field would contain an error as well.
That is not always the case; for example,
the imports_missing package in the added test script
had DepsErrors set but Error empty, causing a nil dereference panic.

Make the code more robust, and report both kinds of load errors.

Fixes #694.

2 Commits (4a13321052133b2c26ac602d8027c3408bd7d469)