CONTRIBUTING: clarify that tests are required

See https://github.com/burrowers/garble/issues/121#issuecomment-695935859.

In some rare cases, it's nearly impossible to write a test for a change,
but they are truly so rare that we shouldn't give any ideas here.

By default, all contributors should try to write a test for every
change that changes what the code is meant to do.
pull/138/head
Daniel Martí 5 years ago
parent 46c111325f
commit dc76318e91

@ -5,7 +5,8 @@ Thank you for your interest in contributing! Here are some ground rules:
1. The tool's design decisions are in the [README](README.md)
2. New features or major changes should be opened as an issue first
3. All contributions are done in PRs with at least one review and CI
4. We use the `#obfuscation` channel over at the [Gophers Slack](https://invite.slack.golangbridge.org/) to chat
4. All changes that alter behavior (features, flags, bugs) need a test
5. We use the `#obfuscation` channel over at the [Gophers Slack](https://invite.slack.golangbridge.org/) to chat
When contributing for the first time, you should also add yourself to the
[AUTHORS file](AUTHORS).

Loading…
Cancel
Save