From c0c5a75454ea50120154e7f6da4fb20285ab9389 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 2 Mar 2021 12:47:31 +0000 Subject: [PATCH] testdata: fix flakiness of tiny.txt on Windows (#252) Sometimes it prints relatively low addresses, like: (0xbc200,0xdd658) We required 6 to 8 hex digits, and sometimes it printed 5. Make the regular expression more conservative. Fixes #184. --- testdata/scripts/tiny.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testdata/scripts/tiny.txt b/testdata/scripts/tiny.txt index 8b692fb..93194d9 100644 --- a/testdata/scripts/tiny.txt +++ b/testdata/scripts/tiny.txt @@ -5,7 +5,7 @@ garble -tiny build ! binsubstr main$exe 'main.go' 'fmt/print.go' env GODEBUG='allocfreetrace=1,gcpacertrace=1,gctrace=1,inittrace=1,scavenge=1,scavtrace=1,scheddetail=1,schedtrace=10' ! exec ./main$exe -stderr '^\(0x[\d\w]{6,8},0x[\d\w]{6,8}\)' # interfaces/pointers print correctly +stderr '^\(0x[\d\w]{4,8},0x[\d\w]{4,8}\)' # interfaces/pointers print correctly # TODO: Make -tiny remove all line information again. # Right now, we reset each declaration's start line to 1. # Better than nothing, but we could still make *all* line numbers 1.