reuse the first call to 'go env'
We need to call 'go env GOPRIVATE' instead of just using os.Getenv so that we pick up the value from the new ${CONFIG}/go/env file, written by 'go env -w'. However, we were calling 'go env' at every process start, including the often tens or hundreds of compiler calls to build all the dependencies. Instead, do that only once on the first 'garble build' process, and use os.Setenv to pass that along to future garble sub-processes. name old time/op new time/op delta Build-8 1.81s ± 0% 1.74s ± 4% -3.78% (p=0.030 n=5+6) name old sys-time/op new sys-time/op delta Build-8 1.45s ± 2% 1.22s ± 1% -16.07% (p=0.002 n=6+6) name old user-time/op new user-time/op delta Build-8 10.9s ± 1% 10.6s ± 1% -2.82% (p=0.004 n=6+5)pull/101/head
parent
fe0def8db9
commit
a4a4500104
Loading…
Reference in New Issue