From 96356e9015e149bf75dc21772dafb271ac0b0f75 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sat, 4 Jan 2025 22:23:38 +0000
Subject: [PATCH] rename reflectedObjectString for clarity

This function returns obfuscated names, so use that as its name.
Moreover, some of the callers still called the result "objStr",
which misled me into thinking the string was a unique object path.

Leave a TODO behind about using go/types/objectpath too.
Our own recordedObjectString is sort of similar, but not as principled.
---
 reflect.go | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/reflect.go b/reflect.go
index e95198b..7233e24 100644
--- a/reflect.go
+++ b/reflect.go
@@ -464,9 +464,9 @@ func recordedObjectString(obj types.Object) objectString {
 	return pkg.Path() + "." + obj.Name()
 }
 
-// reflectedObjectString returns the obfucated name of a types.Object,
+// obfuscatedObjectName returns the obfucated name of a types.Object,
 // parent is needed to correctly get the obfucated name of struct fields
-func reflectedObjectString(obj types.Object, parent *types.Struct) string {
+func obfuscatedObjectName(obj types.Object, parent *types.Struct) string {
 	if obj == nil {
 		return ""
 	}
@@ -489,19 +489,22 @@ func (ri *reflectInspector) recordUsedForReflect(obj types.Object, parent *types
 	if obj.Pkg().Path() != ri.pkg.Path() {
 		panic("called recordUsedForReflect with a foreign object")
 	}
-	objStr := reflectedObjectString(obj, parent)
-	if objStr == "" {
+	obfName := obfuscatedObjectName(obj, parent)
+	if obfName == "" {
 		return
 	}
-	ri.result.ReflectObjectNames[objStr] = obj.Name()
+	ri.result.ReflectObjectNames[obfName] = obj.Name()
 }
 
 func usedForReflect(cache pkgCache, obj types.Object) bool {
-	objStr := reflectedObjectString(obj, nil)
-	if objStr == "" {
+	obfName := obfuscatedObjectName(obj, nil)
+	if obfName == "" {
 		return false
 	}
-	_, ok := cache.ReflectObjectNames[objStr]
+	// TODO: Note that this does an object lookup by obfuscated name.
+	// We should probably use unique object identifiers or strings,
+	// such as go/types/objectpath.
+	_, ok := cache.ReflectObjectNames[obfName]
 	return ok
 }