From 93129386507f1bb00528c624d42d675f606d0117 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sun, 14 Mar 2021 22:07:03 +0000 Subject: [PATCH] remove obsolete TODOs (#274) obfuscatedTypesPackage can't be outright removed, since we still do require knowledge of what was obfuscated for one reason: types used with reflection. Since we can only figure that out with go/ast and not just go/types, we rely on the original compilation to tell us that information. IgnoreFuncBodies=true for typechecking the original source code would be nice, as we would save time, but ultimately it doesn't work. When we rename top-level declarations such as functions and types, we also need to amend their references in func bodies. We depend on type information for that. Finally, we've been randomizing filenames for a while now. Randomizing the order of the files doesn't seem to be useful. --- main.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/main.go b/main.go index c5a2c33..3b308e4 100644 --- a/main.go +++ b/main.go @@ -115,10 +115,6 @@ var ( envGoPrivate = os.Getenv("GOPRIVATE") // complemented by 'go env' later ) -// TODO(mvdan): now that we also obfuscate assembly funcs, we could likely get -// rid of obfuscatedTypesPackage and have a function that tells us if a -// *types.Func (from the original types.Package) should be obfuscated. - func obfuscatedTypesPackage(path string) *types.Package { entry, ok := importCfgEntries[path] if !ok { @@ -578,7 +574,6 @@ func transformCompile(args []string) ([]string, error) { origImporter = importer.Default() } - // TODO(mvdan): can we use IgnoreFuncBodies=true? origTypesConfig := types.Config{Importer: origImporter} tf.pkg, err = origTypesConfig.Check(curPkg.ImportPath, fset, files, tf.info) if err != nil { @@ -617,7 +612,6 @@ func transformCompile(args []string) ([]string, error) { flags = flagSetValue(flags, "-p", newPkgPath) } - // TODO: randomize the order and names of the files newPaths := make([]string, 0, len(files)) for i, file := range files { origName := filepath.Base(filepath.Clean(paths[i]))