From 6ac7dce4a09bea215b4cd628917f3a2911377bc5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Mon, 19 Apr 2021 21:32:06 +0100 Subject: [PATCH] remove obsolete TODO in the tiny.txt test Since 1a8e32227f we have been setting line numbers on call sites, and that line number is always the minimum value for -tiny: 1. Still not as zero-overhead as the old mechanism which entirely deleted line numbers, but a useless and small line number is still pretty good. --- testdata/scripts/tiny.txt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/testdata/scripts/tiny.txt b/testdata/scripts/tiny.txt index ede34ea..103dce2 100644 --- a/testdata/scripts/tiny.txt +++ b/testdata/scripts/tiny.txt @@ -6,11 +6,9 @@ garble -tiny build env GODEBUG='allocfreetrace=1,gcpacertrace=1,gctrace=1,inittrace=1,scavenge=1,scavtrace=1,scheddetail=1,schedtrace=10' ! exec ./main$exe stderr '^\(0x[\d\w]{4,8},0x[\d\w]{4,8}\)' # interfaces/pointers print correctly -# TODO: Make -tiny remove all line information again. -# Right now, we reset each declaration's start line to 1. -# Better than nothing, but we could still make *all* line numbers 1. -# stderr '^caller: \? 0$' # position info is removed -stderr '^caller: \?\? ' # position info is removed +# With -tiny, all line numbers are reset to 1. +# Unfortunately, line comment directives don't allow erasing line numbers entirely. +stderr '^caller: \?\? 1$' # position info is removed stderr '^recovered: ya like jazz?' ! stderr 'panic: oh noes' # panics are hidden