From 51ee956e90ae60453b99709ef3166b53921e6ea6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sat, 31 Aug 2024 01:39:07 +0100 Subject: [PATCH] disable linker.txtar as it's broken by design on Go 1.23 Updates #859. --- testdata/script/linker.txtar | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/testdata/script/linker.txtar b/testdata/script/linker.txtar index 8bb48da..0185756 100644 --- a/testdata/script/linker.txtar +++ b/testdata/script/linker.txtar @@ -1,3 +1,9 @@ +# This test stopped working on Go 1.23, as linknaming into the runtime +# is now forbidden since https://go.dev/issue/67401. +# Perhaps rewrite this test by searching for the pcheader magic number +# by scanning the binary, like debug/buildinfo/buildinfo.go does in searchMagic. +skip 'no longer works on Go 1.23' + # Past garble versions might not properly patch cmd/link with "git apply" # when running inside a git repository. Skip the extra check with -short. [!short] [exec:git] exec git init -q