From 3d196057824a258736c11828392ef93b25e61a69 Mon Sep 17 00:00:00 2001
From: lu4p <lu4p@pm.me>
Date: Fri, 22 Oct 2021 15:11:14 +0200
Subject: [PATCH] Fix linkname directives with dots in importpath (#407)

Obfuscating newName arguments of linkname directives
with dots in the importpath didn't work before.

We had a test which covers this,
but the corresponding package wasn't actually obfuscated.
---
 main.go                       | 11 ++---------
 testdata/scripts/linkname.txt |  2 +-
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/main.go b/main.go
index 2cc89a5..53103b4 100644
--- a/main.go
+++ b/main.go
@@ -731,15 +731,8 @@ func (tf *transformer) handleDirectives(comments []*ast.CommentGroup) {
 
 			// If the package path has multiple dots, split on the
 			// last one.
-			var pkgPath, name string
-			if dotCnt == 1 {
-				target := strings.Split(newName, ".")
-				pkgPath, name = target[0], target[1]
-			} else {
-				lastDotIdx := strings.LastIndex(newName, ".")
-				target := strings.Split(newName[lastDotIdx-1:], ".")
-				pkgPath, name = target[0], target[1]
-			}
+			lastDotIdx := strings.LastIndex(newName, ".")
+			pkgPath, name := newName[:lastDotIdx], newName[lastDotIdx+1:]
 
 			lpkg, err := listPackage(pkgPath)
 			if err != nil {
diff --git a/testdata/scripts/linkname.txt b/testdata/scripts/linkname.txt
index b0cd89c..abe5ff0 100644
--- a/testdata/scripts/linkname.txt
+++ b/testdata/scripts/linkname.txt
@@ -1,4 +1,4 @@
-env GOPRIVATE=test/main
+env GOPRIVATE=test/main,big.chungus/meme
 
 garble build
 exec ./main