From 30df5e9bbd677fa31f6562d3ab7a43edd203982b Mon Sep 17 00:00:00 2001 From: Andrew LeFevre Date: Wed, 2 Sep 2020 14:00:13 -0400 Subject: [PATCH] Disable plugin test (#120) * disable plugin test for now, add note to README * add link to issue in README * fix README link to issue --- README.md | 5 +++-- testdata/scripts/plugin.txt | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 09118e5..f337adb 100644 --- a/README.md +++ b/README.md @@ -64,8 +64,9 @@ to document the current shortcomings of this tool. * Functions implemented outside Go, such as assembly, aren't garbled since we currently only transform the input Go source. -* Since `garble` forces `-trimpath`, plugins built with `-garble` must be loaded - from Go programs built with `-trimpath` too. +* ~~Since `garble` forces `-trimpath`, plugins built with `-garble` must be loaded + from Go programs built with `-trimpath` too.~~ Plugins currently do not always + work with well with `garble`; see [#87](https://github.com/mvdan/garble/issues/87). ### Runtime API diff --git a/testdata/scripts/plugin.txt b/testdata/scripts/plugin.txt index 0ef0869..08d1ea4 100644 --- a/testdata/scripts/plugin.txt +++ b/testdata/scripts/plugin.txt @@ -1,3 +1,5 @@ +skip # TODO: get plugins working properly. See issue #87 + [windows] skip 'Go plugins are not supported on Windows' env GOPRIVATE=test/main