From 02de9158b691e5b1e12113617ec2a5991ae6bbc6 Mon Sep 17 00:00:00 2001
From: lu4p <lu4p@pm.me>
Date: Fri, 14 Aug 2020 20:09:43 +0200
Subject: [PATCH] Fix reflect detection if -literals is passed. Fixes #93.

The second typecheck lead to the creation of different type objects,
which didn't match the types in the blacklist anymore.

It turns out we don't need the second typecheck,
therfore it is now removed.
---
 main.go                      | 5 -----
 testdata/scripts/imports.txt | 5 +++++
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/main.go b/main.go
index 4a790c3..3483a36 100644
--- a/main.go
+++ b/main.go
@@ -450,11 +450,6 @@ func transformCompile(args []string) ([]string, error) {
 
 	if envGarbleLiterals {
 		files = literals.Obfuscate(files, info, fset, blacklist)
-		// ast changed so we need to typecheck again
-		pkg, err = origTypesConfig.Check(pkgPath, fset, files, info)
-		if err != nil {
-			return nil, fmt.Errorf("typecheck error: %v", err)
-		}
 	}
 
 	tempDir, err := ioutil.TempDir("", "garble-build")
diff --git a/testdata/scripts/imports.txt b/testdata/scripts/imports.txt
index 108d01f..050f3b5 100644
--- a/testdata/scripts/imports.txt
+++ b/testdata/scripts/imports.txt
@@ -16,6 +16,11 @@ go build -tags buildtag
 exec ./main
 cmp stdout main.stdout
 
+# Also check that -literals doesn't break anything
+garble -literals build -tags buildtag
+exec ./main
+cmp stdout main.stdout
+
 -- go.mod --
 module test/main
 -- main.go --